Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23906 )
Change subject: IMPALA-13122: Add detailed file metadata statistics to table loading logs ...................................................................... Patch Set 2: About the catalogd logs: assert_catalogd_log_contains() is only used in custom cluster tests, probably it doesn't work in normal tests. The following suggests that it may need non-default flags to work: https://github.com/apache/impala/blob/3dac0135fba0717dd977043e7ecc6b52bf55189f/tests/common/impala_test_suite.py#L1664C7-L1664C18 It also doesn't seem reliable in EE tests by design, even if only one test is run in parallel: the function doesn't check if the log line comes from the given query (e.g. by checking timestamp of log lines) and a previous test can make the log "dirty". This is ok in tests that always restart catalog (and create a new log file). It would be nice to improve the log detection logic by ignoring older log lines, but in this case I think that it is ok to simply not write automatic tests at all and just write in the commit message that the logs were checked manually. -- To view, visit http://gerrit.cloudera.org:8080/23906 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f4592f173c047e5064058402f83be6d1f5c9a79 Gerrit-Change-Number: 23906 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 28 Jan 2026 16:39:22 +0000 Gerrit-HasComments: No
