Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23877 )
Change subject: IMPALA-10913: Produce Ranger audit log for SHOW DATABASES ...................................................................... Patch Set 3: (5 comments) I have addressed Quanlong's comments on patch set 2. Let me know if there are additional suggestions. Thanks a lot for the help! http://gerrit.cloudera.org:8080/#/c/23877/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23877/2//COMMIT_MSG@19 PS2, Line 19: when R > nit: use a permalink to avoid this get stale. Done http://gerrit.cloudera.org:8080/#/c/23877/2/fe/src/main/java/org/apache/impala/authorization/Authorizable.java File fe/src/main/java/org/apache/impala/authorization/Authorizable.java: http://gerrit.cloudera.org:8080/#/c/23877/2/fe/src/main/java/org/apache/impala/authorization/Authorizable.java@36 PS2, Line 36: DB_LIST > Could you mention this in the commit message? Sure. > Does NONE only correspond to the db list? Yes. http://gerrit.cloudera.org:8080/#/c/23877/2/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/23877/2/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@168 PS2, Line 168: // This should happen for SHOW DATABASES only. > How about renaming NONE to DB_LIST ? Thanks Quanlong! I think this is a good idea. Will address this comment in the next patch. http://gerrit.cloudera.org:8080/#/c/23877/2/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/23877/2/tests/authorization/test_ranger.py@809 PS2, Line 809: enable > nit: use 'enable' directly? Done http://gerrit.cloudera.org:8080/#/c/23877/2/tests/authorization/test_ranger.py@3465 PS2, Line 3465: (self): > nit: the class name TestRangerLocalCatalog already mentions local catalog s Sure. I will make the method name shorter in the next patch. -- To view, visit http://gerrit.cloudera.org:8080/23877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb3e54b152e953916d3d7d7ef27c880a8559ed26 Gerrit-Change-Number: 23877 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 30 Jan 2026 00:28:54 +0000 Gerrit-HasComments: Yes
