Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23891 )
Change subject: Refactor FeTable ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23891/3/fe/src/main/java/org/apache/impala/catalog/Column.java File fe/src/main/java/org/apache/impala/catalog/Column.java: http://gerrit.cloudera.org:8080/#/c/23891/3/fe/src/main/java/org/apache/impala/catalog/Column.java@159 PS3, Line 159: : /** : * Filter columns not stored in HMS (currently row__id in full ACID tables). : */ : public static List<Column> filterColumnsNotStoredInHms(org.apache.hadoop.hive.metastore.api.Table tbl, List<Column> columns) { : boolean isFullAcid = tbl != null && AcidUtils.isFullAcidTable(tbl.getParameters()); : if (!isFullAcid) return columns; : // Filter out row__id as it doesn't exist in HMS. : return columns.stream() : .filter(c -> !c.getName().equals("row__id")) : .collect(Collectors.toList()); : } : : : /** : * Returns a list of thrift column descriptors ordered by position. : */ : public static List<TColumnDescriptor> toTColumnDescriptors(List<Column> columns) { : List<TColumnDescriptor> colDescs = new ArrayList<>(); : for (Column col: columns) { : colDescs.add(col.toDescriptor()); : } : return colDescs; : } : : nit: indenting is off (2 spaces) http://gerrit.cloudera.org:8080/#/c/23891/3/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/23891/3/fe/src/main/java/org/apache/impala/catalog/Table.java@53 PS3, Line 53: import org.apache.impala.thrift.*; Please keep the original imports. -- To view, visit http://gerrit.cloudera.org:8080/23891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia39a77c11b921d19f7a0c42266ff350993a25d01 Gerrit-Change-Number: 23891 Gerrit-PatchSet: 3 Gerrit-Owner: Nandor Kollar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 30 Jan 2026 08:59:17 +0000 Gerrit-HasComments: Yes
