Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23931 )
Change subject: IMPALA-14715: Fix CMake AVX2 check ...................................................................... IMPALA-14715: Fix CMake AVX2 check Impala currently has two different checks for AVX2 compiler support: one in be/src/util and another from Kudu in be/src/kudu/util. The Kudu one is currently broken for the Impala build, disabling AVX2 support for blocked bloom filters. This seems to be specific to Impala's toolchain CMake 3.22.2. Other versions of CMake (e.g. 3.22.1 on Ubuntu 22 or 3.31.10) work properly. This centralizes the AVX2 check and uses the working version from be/src/util. To prevent future issues, it fails the build if AVX2 support is not detected on x86_64. In order to be easy to backport, this does not upgrade CMake (but that will happen separately). Testing: - Ran build on my local x86_64 machine and verified the compilation flags for Impala's parquet bloom filters, Kudu's block bloom filters, and roaring bitmap all reflect AVX2 support. Change-Id: If34820a1a0d70e54df0859ec6d524b178367db0a Reviewed-on: http://gerrit.cloudera.org:8080/23931 Reviewed-by: Jason Fehr <[email protected]> Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/CMakeLists.txt M be/src/kudu/util/CMakeLists.txt M be/src/util/CMakeLists.txt 3 files changed, 27 insertions(+), 22 deletions(-) Approvals: Jason Fehr: Looks good to me, but someone else must approve Michael Smith: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/23931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If34820a1a0d70e54df0859ec6d524b178367db0a Gerrit-Change-Number: 23931 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
