Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23894 )
Change subject: IMPALA-10706: Remove unnecessary metastoreAccessLock_ from TableLoader ...................................................................... IMPALA-10706: Remove unnecessary metastoreAccessLock_ from TableLoader The metastoreAccessLock_ was added as a workaround for HIVE-5457, a DataNucleus concurrency bug from 2013 that occurred when directly connecting to the Hive Metastore backend database. This lock is no longer necessary because: - Impala uses RetryingMetaStoreClient (thrift client) to connect to HMS over the network, not directly to the database - The HIVE-5457 bug only affected direct DB connections via DataNucleus - HMS handles concurrency internally via its own connection pooling Removing this lock allows concurrent getTable() calls, improving metadata loading performance. Testing: Verified no remaining references to metastoreAccessLock_ exist. Full testing will be done via gerrit-verify-dryrun. Written with assistance from Antigravity (Claude Opus 4.5 model). Change-Id: Id480c474c6a095e95a6f412e835a23dd7880f3f1 Reviewed-on: http://gerrit.cloudera.org:8080/23894 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/catalog/TableLoader.java 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id480c474c6a095e95a6f412e835a23dd7880f3f1 Gerrit-Change-Number: 23894 Gerrit-PatchSet: 4 Gerrit-Owner: Kunal Siyag <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kunal Siyag <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
