Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23916 )

Change subject: IMPALA-13921: Make Java 17 the default in tests
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23916/5/docker/install_os_packages.sh
File docker/install_os_packages.sh:

http://gerrit.cloudera.org:8080/#/c/23916/5/docker/install_os_packages.sh@29
PS5, Line 29: JAVA_VERSION=17
We should also clean up docker/CMakeLists.txt. See 
https://github.com/apache/impala/blob/master/docker/CMakeLists.txt#L117-L133

We specify multiple sets of docker images. The default ones use Java 8 right 
now (e.g. catalogd). Others use a specific java version (e.g. catalogd_java17).

This switches the default to java 17, so we could handle it by removing the 
explicit java 17 images and adding explicit java 8 images. (Though, we're going 
to be removing java 8 / 11 at some point.)



--
To view, visit http://gerrit.cloudera.org:8080/23916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99cc3b752142e6936a039c02505e3c35e71277aa
Gerrit-Change-Number: 23916
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: ttttttz <[email protected]>
Gerrit-Comment-Date: Tue, 03 Feb 2026 17:41:08 +0000
Gerrit-HasComments: Yes

Reply via email to