Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20778 )

Change subject: IMPALA-3192: Add fetch.sh to download prebuilt artifacts
......................................................................


Patch Set 5:

(1 comment)

> Patch Set 5: Code-Review+1
>
> (1 comment)
>
> This makes sense to me and I'd be willing to go to +2

In practice I've found this marginally useful. It's usually quicker to copy 
directories from an Impala dev environment and add the required check/ files.

http://gerrit.cloudera.org:8080/#/c/20778/5/fetch.sh
File fetch.sh:

http://gerrit.cloudera.org:8080/#/c/20778/5/fetch.sh@35
PS5, Line 35: TOOLCHAIN_HOST=native-toolchain.s3.amazonaws.com
> Nit: Would it be useful for this to respect the existing value of IMPALA_TO
Yeah, makes sense.



--
To view, visit http://gerrit.cloudera.org:8080/20778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2914bd7d5e0589200d114218fbe107bec0b1f8a2
Gerrit-Change-Number: 20778
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Wed, 04 Feb 2026 21:14:46 +0000
Gerrit-HasComments: Yes

Reply via email to