Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23569 )
Change subject: IMPALA-14507: Register column-level privilege requests for INSERT ...................................................................... Patch Set 23: (3 comments) http://gerrit.cloudera.org:8080/#/c/23569/23//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23569/23//COMMIT_MSG@9 PS23, Line 9: This patch registers column-level privilege requests for columns : involved in the INSERT statement so that the requesting user does not : need to be granted the INSERT privilege on the entire table. What happens if the DML inserts into all columns? Will Impala register requests for all columns? http://gerrit.cloudera.org:8080/#/c/23569/23//COMMIT_MSG@56 PS23, Line 56: e) column-level Ranger audit events could be produced after the : introduction of column-level INSERT privilege, Can you mention this change also earlier in the commit message? BTW can't this increase the number of audit log entries drastically? Do you know if Hive works the same? http://gerrit.cloudera.org:8080/#/c/23569/23/fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java: http://gerrit.cloudera.org:8080/#/c/23569/23/fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java@660 PS23, Line 660: String json = String.format("{\n" + optional: using multiline strings (""") would make this more readable -- To view, visit http://gerrit.cloudera.org:8080/23569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ef61801d3b394c56702b193c250492a62b111df Gerrit-Change-Number: 23569 Gerrit-PatchSet: 23 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 05 Feb 2026 07:41:48 +0000 Gerrit-HasComments: Yes
