Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10493 )
Change subject: IMPALA-110 (part 1): Refactor ExecNode::buffer_pool_client_ ...................................................................... IMPALA-110 (part 1): Refactor ExecNode::buffer_pool_client_ IMPALA-110 will involve refactoring PartitionedAggregationNode by separating out the aggregation logic into a new type called Aggregator, and then supporting multiple Aggregators per node to allow for multiple aggregation classes to be evaluated at the same time. Each Aggregator will need to have its own memory reservation to operate, and we can do this by giving each Aggregator its own BufferPool::ClientHandle instead of using the usual ExecNode::buffer_pool_client_. To facilitate this, this patch refactors all of the buffer_pool_client_ related logic into a new class, ReservationManager, so that eventually each Aggregator can have its own ReservationManager and the logic in ClaimBufferReservation(), ReleaseUnusedReservation(), etc. won't be duplicated. Testing: - Passed a full run of the core tests. Change-Id: I75f92c3f4f05adeef11a70f59e0c8ff2d19bc17a Reviewed-on: http://gerrit.cloudera.org:8080/10493 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/analytic-eval-node.cc M be/src/exec/exec-node.cc M be/src/exec/exec-node.h M be/src/exec/hdfs-scan-node-base.cc M be/src/exec/hdfs-scan-node-mt.cc M be/src/exec/hdfs-scan-node.cc M be/src/exec/partial-sort-node.cc M be/src/exec/partitioned-aggregation-node.cc M be/src/exec/partitioned-hash-join-node.cc M be/src/exec/sort-node.cc M be/src/runtime/CMakeLists.txt A be/src/runtime/reservation-manager.cc A be/src/runtime/reservation-manager.h 13 files changed, 288 insertions(+), 164 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I75f92c3f4f05adeef11a70f59e0c8ff2d19bc17a Gerrit-Change-Number: 10493 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
