Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23944 )
Change subject: IMPALA-14724: Add support for using soft references in CatalogdMetaProvider ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23944/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/23944/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@401 PS1, Line 401: builder = builder.softValues(); The doc mentions that when this method is used, the resulting cache will use identity (==) comparison to determine equality of values. I'm not sure if "values" here means all objects in the cache including the keys. If so, it impacts the key matching in loadWithCaching(). It'd be nice to test this. https://guava.dev/releases/32.1.2-jre/api/docs/com/google/common/cache/CacheBuilder.html#softValues() -- To view, visit http://gerrit.cloudera.org:8080/23944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10efb6743d2f9e5b8cc47cdcc9c5893b005b9aa5 Gerrit-Change-Number: 23944 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 06 Feb 2026 08:33:22 +0000 Gerrit-HasComments: Yes
