Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23789 )
Change subject: IMPALA-14535: Improve wait for HMS events sync with hierarchical event processing ...................................................................... Patch Set 6: (3 comments) The e2e TestEventSyncWaiting in dockerised run seems to spend more time after this patch (26m vs. 21m). https://jenkins.impala.io/job/ubuntu-20.04-dockerised-tests/4615/testReport/metadata.test_event_processing/TestEventSyncWaiting/ master run: https://jenkins.impala.io/job/ubuntu-20.04-dockerised-tests/4641/testReport/metadata.test_event_processing/TestEventSyncWaiting/ The difference mostly comes from test_view_partitioned (8m5s vs. 4m4s). Could you take a look? http://gerrit.cloudera.org:8080/#/c/23789/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/23789/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@2021 PS6, Line 2021: eventExecutorService_.isProcessed(dbName, latestEventId)); nit: when removeIf() returns true (meaning something is removed), let's log the remaining dbNames or saying "all required db events are synced" if dbNames is empty. http://gerrit.cloudera.org:8080/#/c/23789/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@2027 PS6, Line 2027: eventExecutorService_.isProcessed(entry.getKey(), tableName, latestEventId)); nit: let's also add a similar log here for tables. http://gerrit.cloudera.org:8080/#/c/23789/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@2034 PS6, Line 2034: Uninterruptibles.sleepUninterruptibly(sleepIntervalMs, TimeUnit.MILLISECONDS); nit: it'd also be helpful to log a waiting message like the single-threaded mode. https://github.com/apache/impala/blob/1753c3aa7c4829882fd9d32518da9b7a667f5cf1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java#L1927-L1930 -- To view, visit http://gerrit.cloudera.org:8080/23789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55cea4cb8e04860202e56e1b1bf2596613b4946c Gerrit-Change-Number: 23789 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 09 Feb 2026 13:52:14 +0000 Gerrit-HasComments: Yes
