Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/23932 )
Change subject: IMPALA-12374: Optimize trailing/leading % in LIKE ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/23932/7/be/src/benchmarks/expr-benchmark.cc File be/src/benchmarks/expr-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/23932/7/be/src/benchmarks/expr-benchmark.cc@320 PS7, Line 320: > optional: I think that this would be more readable by creating the 4 string Done http://gerrit.cloudera.org:8080/#/c/23932/7/be/src/exprs/like-predicate.cc File be/src/exprs/like-predicate.cc: http://gerrit.cloudera.org:8080/#/c/23932/7/be/src/exprs/like-predicate.cc@110 PS7, Line 110: RE2::FullMatch(pattern_str, leading_trailing_re, &trimmed_pattern) && > optional: I think that this function would be easier to understand with a s Done -- To view, visit http://gerrit.cloudera.org:8080/23932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37b472e056f791035d25633f17ad8a6e841cdd18 Gerrit-Change-Number: 23932 Gerrit-PatchSet: 8 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 10 Feb 2026 10:28:02 +0000 Gerrit-HasComments: Yes
