ji chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/23793 )
Change subject: IMPALA-14092 Part3: Enable predicate pushdown for paimon table. ...................................................................... Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/23793/6/fe/src/main/java/org/apache/impala/planner/PaimonScanNode.java File fe/src/main/java/org/apache/impala/planner/PaimonScanNode.java: http://gerrit.cloudera.org:8080/#/c/23793/6/fe/src/main/java/org/apache/impala/planner/PaimonScanNode.java@119 PS6, Line 119: return true; > nit: can we simplify this to just Done http://gerrit.cloudera.org:8080/#/c/23793/4/fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java File fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java: http://gerrit.cloudera.org:8080/#/c/23793/4/fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java@194 PS4, Line 194: t getAttributeFieldIndex(SlotR > This comment was not resolved. Done http://gerrit.cloudera.org:8080/#/c/23793/4/fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java@199 PS4, Line 199: ect convertLiteral(String field > This comment was not resolved. Done http://gerrit.cloudera.org:8080/#/c/23793/6/fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java File fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java: http://gerrit.cloudera.org:8080/#/c/23793/6/fe/src/main/java/org/apache/impala/planner/paimon/ImpalaExprConverter.java@111 PS6, Line 111: c > Would it be possible to output the compoundPredicate? So users will know wh Done http://gerrit.cloudera.org:8080/#/c/23793/4/fe/src/main/java/org/apache/impala/planner/paimon/PredicateExtractor.java File fe/src/main/java/org/apache/impala/planner/paimon/PredicateExtractor.java: http://gerrit.cloudera.org:8080/#/c/23793/4/fe/src/main/java/org/apache/impala/planner/paimon/PredicateExtractor.java@90 PS4, Line 90: prs.isEmpty()) { return n > So my understanding is that exprs in pushedExprs_ are evaluated by the Java the exprs in pushedExprs_ includes expressions can be pushed down to Java Paimon Scanner, the pushed expressions has 2 categories, 1. partition expressions, for partition expression, the paimon scanner guarentees the data is accurately filtered , for this category, the partition expression is ok not to add it to postScanExprs_. 2. for other pushed expressions, although the expression is pushed, paimon java scanner can't guarentee the data is accurately filtered, it only exclude unnecessary row-groups, for this case, we need to add the expression to postScanExprs_ to filter is again in c++ scanner. Current implementation the non-partition related expressions will be added to postScanExprs_ for further filtering, partition related filter expression will NOT be added to postScanExprs_ to reduce overhead of c++ scanner. But I think it is ok to add partition expressions to postScanExprs_ if the overhead can be ignored. if you think it is better to add partition expression to postScanExprs_, I will add it. http://gerrit.cloudera.org:8080/#/c/23793/6/fe/src/main/java/org/apache/impala/planner/paimon/PredicateExtractor.java File fe/src/main/java/org/apache/impala/planner/paimon/PredicateExtractor.java: http://gerrit.cloudera.org:8080/#/c/23793/6/fe/src/main/java/org/apache/impala/planner/paimon/PredicateExtractor.java@40 PS6, Line 40: * ExtractedPredicates hold the predicate pushdown result from PredicateExtractor > style nit: Done -- To view, visit http://gerrit.cloudera.org:8080/23793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee07fa35de8381121a20b2976d6424626d705483 Gerrit-Change-Number: 23793 Gerrit-PatchSet: 7 Gerrit-Owner: ji chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: ji chen <[email protected]> Gerrit-Comment-Date: Tue, 10 Feb 2026 22:37:19 +0000 Gerrit-HasComments: Yes
