Hello Quanlong Huang, Jason Fehr, Zoltan Borok-Nagy, Csaba Ringhofer, Impala
Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23955
to look at the new patch set (#10).
Change subject: IMPALA-13419: Improve test_http_socket_timeout
......................................................................
IMPALA-13419: Improve test_http_socket_timeout
Uses a debug action in ExecuteStatement to add a sleep so we can test a
longer http_socket_timeout_s setting, which makes the test more
consistent. Fixes test failures with ASAN builds.
The change in testing means the failure no longer happens during 'SET
ALL' - which was too quick to be reliable - where impala-shell would
then CloseSession after failure. It now happens during executing the
query, which can result in leaving a query behind after the connection
is closed. Moves the test to custom cluster testing because there's no
way to reliably ensure the session is closed after disconnect;
idle_session_timeout should in theory work, but impala-shell has no way
to set it and detecting closed connections takes too long.
Fixes a DCHECK failure exposed by this test where registration fails
because the session has been closed and therefore the query driver was
not finalized:
760958 impala-server.cc:1522] ...] RegisterQuery(): session has been closed,
ignoring query.
760958 query-driver.cc:46] Check failed: finalized_.Load() Finalize() must
have been called
Testing: ran test_http_socket_timeout a bunch of times with ASAN.
Change-Id: Idf31bb1752586ebc296e5e8d62c035bac7371dfb
---
M be/src/runtime/query-driver.cc
M be/src/runtime/query-driver.h
M be/src/service/impala-server.cc
M tests/custom_cluster/test_shell_commandline.py
M tests/shell/test_shell_commandline.py
5 files changed, 55 insertions(+), 55 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/23955/10
--
To view, visit http://gerrit.cloudera.org:8080/23955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf31bb1752586ebc296e5e8d62c035bac7371dfb
Gerrit-Change-Number: 23955
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
