Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23962
to look at the new patch set (#2).
Change subject: IMPALA-14714: Fix incorrect results for anti-join with constant
ON clause predicates
......................................................................
IMPALA-14714: Fix incorrect results for anti-join with constant ON clause
predicates
This patch fixes incorrect query results when using LEFT/RIGHT ANTI JOIN
with constant predicates in the ON clause (e.g., ON FALSE or ON TRUE).
Previously, constant anti-join predicates were incorrectly handled:
- They were marking the entire query as having an empty result set
- They were being assigned to scan nodes instead of join nodes
- They were being migrated into inline views incorrectly
The fix adds special handling for anti-join conjuncts in Analyzer to:
1. Skip them in markConstantConjunct() to avoid marking query as empty
2. Route constant ON clause predicates to canEvalOnClauseConjunct()
3. Ensure constant anti-join predicates are evaluated at join nodes
4. Prevent migration of anti-join predicates into inline views
Testing:
- Added comprehensive test cases covering ON FALSE, ON TRUE, and mixed
predicates for both LEFT and RIGHT ANTI JOIN
Change-Id: I0e0f4a69263bb0ff11f421a1a340dffb904c6842
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M testdata/workloads/functional-query/queries/QueryTest/semi-joins.test
3 files changed, 218 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/23962/2
--
To view, visit http://gerrit.cloudera.org:8080/23962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0e0f4a69263bb0ff11f421a1a340dffb904c6842
Gerrit-Change-Number: 23962
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
