Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23967 )
Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/23967/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23967/3//COMMIT_MSG@13 PS3, Line 13: py3-requirements.txt is folded back into requirements.txt. > Yeah, all of this is with the toolchain Python 3.8, so it should be the sam Ok, here is what I think is happening: py2-requirements.txt had references to pyflakes, mccabe, and pycodestyle. We download all of those along with the other packages from other requirements.txt files. Even though they aren't specified in the py3-requirements.txt, they are available locally, and pip can find them. When I removed py2-requirements.txt, those were no longer being downloaded and things broke. Very weird setup, but that explains why I had to add those dependencies for flake8. http://gerrit.cloudera.org:8080/#/c/23967/3/infra/python/deps/requirements.txt File infra/python/deps/requirements.txt: http://gerrit.cloudera.org:8080/#/c/23967/3/infra/python/deps/requirements.txt@55 PS3, Line 55: futures == 3.3.0; python_version == "2.7" > Do we still need this? Removed http://gerrit.cloudera.org:8080/#/c/23967/3/infra/python/deps/requirements.txt@83 PS3, Line 83: virtualenv == 16.7.10 Also removed this -- To view, visit http://gerrit.cloudera.org:8080/23967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a Gerrit-Change-Number: 23967 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 13 Feb 2026 01:32:59 +0000 Gerrit-HasComments: Yes
