Steve Carlin has posted comments on this change. (
http://gerrit.cloudera.org:8080/23900 )
Change subject: IMPALA-14488: Calcite planner: Support fallback to Original
planner
......................................................................
Patch Set 15:
Ok, sorry about that...I had a slight worry after I submitted the last fix and
I wanted to make sure it was ok.
So first: Apologies: I tested all the other tests, but I forgot about the
ranger one and sigh, that was the one test that failed.
The reason it failed: The failed version had 2 lines to set configuration
options for the test:
non_owner_client.set_configuration({"planner": "CALCITE"})
non_owner_client.set_configuration({"fallback_planner": "CALCITE"})
I had thought that each of these lines would be setting the configuration
parameters. But the second "set_configuration" overwrote the first one. after
the second one, the "planner" went back to the default "ORIGINAL" planner (the
fallback_planner was CALCITE) and that was why the test failed.
I could also have fixed this by combining the 2 query options into the
set_configuration call. But this fix is fine too. Even though the
fallback_planner is ORIGINAL, this isn't a test about whether fallback works
properly, it's a test that ensures that fallback is happening.
In other words: with or without the fallback planner option, this will fallback
to the original planner due to the UnsupportedFeatureException being thrown, so
the test is working as designed.
If you can give this a +1 (sorry, again!), I'd appreciate it!
--
To view, visit http://gerrit.cloudera.org:8080/23900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1fdc5ef92fff84e89af0e19c4246cc15e2ea823
Gerrit-Change-Number: 23900
Gerrit-PatchSet: 15
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Fri, 13 Feb 2026 01:47:32 +0000
Gerrit-HasComments: No
