Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23987 )
Change subject: IMPALA-14749: Fix warning with Python 3.12 ...................................................................... Patch Set 1: One thing is that there is Thrift generated code created by CMake that gets shipped with impala-shell. That is still using the Thrift from the toolchain (0.16.0). If there aren't changes in the generated code, then it shouldn't matter much to use a newer Thrift at runtime. Some options: 1. We could generate the code with a newer Thrift and verify the Python output hasn't changed. 2. We could bump the Thrift version for Python and use it to generate the code. 3. We could bump the Thrift version for everything (Python, C++, Java) -- To view, visit http://gerrit.cloudera.org:8080/23987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1dbbe1b12dc954725bafa55ec5c4b790db9c1b7 Gerrit-Change-Number: 23987 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 17 Feb 2026 21:49:08 +0000 Gerrit-HasComments: No
