Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23906 )
Change subject: IMPALA-13122: Add detailed file metadata statistics to table loading logs ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/23906/5/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java File fe/src/main/java/org/apache/impala/catalog/FeFsTable.java: http://gerrit.cloudera.org:8080/#/c/23906/5/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java@127 PS5, Line 127: public Set<String> uniqueHostDiskPairs = new HashSet<>(); This might be more efficient to track as Pair<Integer, Short>. I don't see any point in converting them to String. Impala has a Pair implementation you can use. Could also consider a bit-shift into a long, but not sure on the trade-off there. http://gerrit.cloudera.org:8080/#/c/23906/5/tests/custom_cluster/test_file_metadata_stats.py File tests/custom_cluster/test_file_metadata_stats.py: http://gerrit.cloudera.org:8080/#/c/23906/5/tests/custom_cluster/test_file_metadata_stats.py@39 PS5, Line 39: @CustomClusterTestSuite.with_args(catalogd_args='--logbuflevel=-1') Do these all need to be restarted? You could move this to the class-level and start one cluster for the whole set of tests. -- To view, visit http://gerrit.cloudera.org:8080/23906 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f4592f173c047e5064058402f83be6d1f5c9a79 Gerrit-Change-Number: 23906 Gerrit-PatchSet: 5 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 18 Feb 2026 19:56:19 +0000 Gerrit-HasComments: Yes
