Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23982 )
Change subject: IMPALA-14738: Adds basic testing for Iceberg V3 tables ...................................................................... Patch Set 3: (2 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/23982/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/23982/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@259 PS2, Line 259: lots()) { : if (!slotDesc.isMaterialized()) continue; > Note to self: seems redundant Done http://gerrit.cloudera.org:8080/#/c/23982/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@265 PS2, Line 265: throw new ImpalaRuntimeException(String.format( > We are checking this only for the materialised SlotRefs right? Not sure but Actually no, this code checks non-materialized SlotRefs as well which is not necessary. E.g., the following queries should work fine: select i from (select * from iceberg_v3_default_value) v; select i from (select i, j from iceberg_v3_default_value) v; select count(*) from (select j from iceberg_v3_default_value) v; As we don't need to materialize the values of 'j' to run these queries, the default value of it is irrelevant. Modified the code, and added new tests. -- To view, visit http://gerrit.cloudera.org:8080/23982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1b90f1af539731d4653e83b848d55517a3acb58 Gerrit-Change-Number: 23982 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 19 Feb 2026 17:45:28 +0000 Gerrit-HasComments: Yes
