Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24006 )
Change subject: IMPALA-14758: Calcite planner: Return value with "in" and case statement crashes server. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24006/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedInPredicate.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedInPredicate.java: http://gerrit.cloudera.org:8080/#/c/24006/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedInPredicate.java@43 PS3, Line 43: public AnalyzedInPredicate(RexCall call, List<Expr> params, Analyzer analyzer) > There's some cleanup you could do around the constructor. It no longer uses Cleaned up the constructor As for the name of the class... I have been using this pattern for naming all the Expr classes that are overridden on the Calcite level. The reason for the name is that it is avoiding the full analysis done in the parent class. Sigh, I know it doesn't totally fit since we are doing a bit of analysis here. But I'm also not sure what to name it. And then maybe I should rename some of the other classes as well? If so, I should do that in a different commit? What do you think? -- To view, visit http://gerrit.cloudera.org:8080/24006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397b8e3438d8f5d59725bed6fc166f842596818f Gerrit-Change-Number: 24006 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 20 Feb 2026 17:20:09 +0000 Gerrit-HasComments: Yes
