Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23974 )

Change subject: IMPALA-12118: Add pytorch cpuinfo
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23974/2/source/cpuinfo/build.sh
File source/cpuinfo/build.sh:

http://gerrit.cloudera.org:8080/#/c/23974/2/source/cpuinfo/build.sh@46
PS2, Line 46: wrap cmake .. -DCMAKE_BUILD_TYPE=RELEASE 
-DCMAKE_INSTALL_PREFIX=$LOCAL_INSTALL \
> Do we really care about a shared lib version of this?
Good point, we don't really use the shared libraries for things this small. 
Dropped.



--
To view, visit http://gerrit.cloudera.org:8080/23974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc154789103965f1b90401a3883188744d9bdb6c
Gerrit-Change-Number: 23974
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Tue, 24 Feb 2026 00:19:36 +0000
Gerrit-HasComments: Yes

Reply via email to