Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24020 )
Change subject: IMPALA-14607: Patch GCC to fix Clang variant compilation issue ...................................................................... IMPALA-14607: Patch GCC to fix Clang variant compilation issue Paimon support for Impala (IMPALA-14092) uses Arrow. Clang 5 is not able to build the code that uses std::variant. The original Impala change applied a patch to libstdc++'s variant header at build time to fix Clang compilation. This applies the same patch during the toolchain build to simplify the fix. This does not change the version number for GCC, so only new toolchains will see the modification. Testing: - Verified that the variant header is now identical to the version after Impala has patched it Change-Id: I52ff4c9b9449d729febfb3260c89df78f82ba086 Reviewed-on: http://gerrit.cloudera.org:8080/24020 Reviewed-by: Joe McDonnell <[email protected]> Reviewed-by: Michael Smith <[email protected]> Tested-by: Joe McDonnell <[email protected]> --- M source/gcc/build.sh A source/gcc/gcc-10.4.0-patches/0002-Fix-variant-compilation-with-clang.patch 2 files changed, 16 insertions(+), 1 deletion(-) Approvals: Joe McDonnell: Looks good to me, but someone else must approve; Verified Michael Smith: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/24020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I52ff4c9b9449d729febfb3260c89df78f82ba086 Gerrit-Change-Number: 24020 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
