Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23967 )
Change subject: IMPALA-14620 (part 1): Remove the Python 2 impala-python virtualenv ...................................................................... IMPALA-14620 (part 1): Remove the Python 2 impala-python virtualenv Previous changes stopped building the Python 2 impala-python virtualenv, but the code is still around. Since Python 2 is dead, this removes that support and simplifies the code: 1. It removes the impala-python Python 2 virtualenv. This removes py2-requirements.txt and folds py3-requirements.txt back into requirements.txt. This also removes various helper scripts for the Python 2 virtualenv. 2. This removes pylint and the check-pylint-py3k.sh script. Pylint is currently only used for the py3k check. This keeps isort separately. 3. It drops the Python 2 virtualenv package and support. 4. This drops IMPALA_USE_PYTHON3_TESTS and adjusts run-tests.py to use impala-python3 directly. 5. This drops the code for producing the Python 2 virtualenv for the shell (and associated packaging code). This also removes the test code for handling the Python 2 shell. This does not drop Python 2 support from impala-shell, so it is still possible to pip install it for Python 2. 6. This drops some code for detecting whether Python supports SSL, which was used for old versions of Python 2. Testing: - Ran a core job Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a Reviewed-on: http://gerrit.cloudera.org:8080/23967 Reviewed-by: Michael Smith <[email protected]> Tested-by: Joe McDonnell <[email protected]> --- M CMakeLists.txt M bin/bootstrap_toolchain.py D bin/check-pylint-py3k.sh M bin/check-python-syntax.sh M bin/cmake_aux/create_virtualenv.sh M bin/impala-config.sh D bin/impala-env-versioned-python D bin/impala-futurize D bin/impala-pip M bin/impala-py.test D bin/impala-pylint D bin/impala-python D bin/impala-python-common.sh M bin/impala-python3-common.sh M bin/impala-shell.sh D bin/impala-virtualenv M bin/init-impala-python.sh M infra/python/bootstrap_virtualenv.py M infra/python/deps/pip_download.py D infra/python/deps/py2-requirements.txt D infra/python/deps/py3-requirements.txt M infra/python/deps/requirements.txt M shell/CMakeLists.txt M shell/packaging/make_shell_tarball.sh M tests/common/network.py M tests/custom_cluster/test_client_ssl.py M tests/custom_cluster/test_thrift_socket.py M tests/run-tests.py M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py M tests/shell/util.py 31 files changed, 84 insertions(+), 699 deletions(-) Approvals: Michael Smith: Looks good to me, approved Joe McDonnell: Verified -- To view, visit http://gerrit.cloudera.org:8080/23967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a Gerrit-Change-Number: 23967 Gerrit-PatchSet: 13 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
