Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24029 )
Change subject: IMPALA-12621: Prevent Thread interrupt flag poisoning of JVM threads ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24029/1/be/src/util/jni-util.h File be/src/util/jni-util.h: http://gerrit.cloudera.org:8080/#/c/24029/1/be/src/util/jni-util.h@539 PS1, Line 539: // Clear interrupt status of JNI thread. : JniUtil::ClearThreadInterruptStatus(env_); For debug builds my preference would be to check both before and after the call, and treat it as a DCHECK if it is interrupted. This would help in pinpointing the culprit - if the "before" DCHECK is hit, then some other Java call was setting interruption, e.g. libhdfs file operations. If the "after" DCHECK is hit, then we know that it happened during the given JNI call. I am not sure about release - calling to JNI has some overhead (practically two calls to JVM instead of one), but our JNI interface is pretty course grained, so probably it wouldn't be noticable. -- To view, visit http://gerrit.cloudera.org:8080/24029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaec6860433431064737e994999dd57a63f223a20 Gerrit-Change-Number: 24029 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 24 Feb 2026 18:30:06 +0000 Gerrit-HasComments: Yes
