Steve Carlin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24031 )
Change subject: IMPALA-14429: (addendum) Only int types need extra conversion. ...................................................................... IMPALA-14429: (addendum) Only int types need extra conversion. A regression was caused with the IMPALA-14429 commit when a decimal was being compared with integers in an IN clause. Calcite only misclassifies integer types, so only those should be changed in the ImpalaRexBuilder when creating literals. Change-Id: Ic41e0141737c771b6d5ea48aa99144a919427207 Reviewed-on: http://gerrit.cloudera.org:8080/24031 Reviewed-by: Aman Sinha <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java M testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q33.test M testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43-verbose.test M testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q43.test M testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q56.test M testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q60.test M testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q61.test M testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q89.test M testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q91.test M testdata/workloads/functional-query/queries/QueryTest/calcite.test 10 files changed, 148 insertions(+), 142 deletions(-) Approvals: Aman Sinha: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/24031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic41e0141737c771b6d5ea48aa99144a919427207 Gerrit-Change-Number: 24031 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]>
