Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10746
to look at the new patch set (#2).
Change subject: IMPALA-7150: fixes jni frame scope
......................................................................
IMPALA-7150: fixes jni frame scope
A previous change (https://gerrit.cloudera.org/#/c/9968/)
reduced the time that a lib-cache entry was held when initializing
a udf. It did so by introducing a new scope. However, that scope
captured a jni frame, which resulted in an earlier frame pop
than before. This change decouples the frame scope from the lib-cache
scope so that the frame is popped at the end of the method (as before)
instread of with the lib-cache scope.
Testing:
- core, asan tests pass
Change-Id: I38d482dde6ed7f8857ae565bf62a8e923ffb0ae9
---
M be/src/exprs/hive-udf-call.cc
1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/10746/2
--
To view, visit http://gerrit.cloudera.org:8080/10746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I38d482dde6ed7f8857ae565bf62a8e923ffb0ae9
Gerrit-Change-Number: 10746
Gerrit-PatchSet: 2
Gerrit-Owner: Vuk Ercegovac <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Vuk Ercegovac <[email protected]>
