Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24037 )
Change subject: IMPALA-14739: Harden CatalogdMetaProvider.Weigher for edge cases ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/24037/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/24037/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@399 PS4, Line 399: cacheSizeBytes / BYTES_PER_WEIGHT_UNIT To be consistent, I think we should use the same formula as L2376, i.e. (cacheSizeBytes - 1) / BYTES_PER_WEIGHT_UNIT + 1. -- To view, visit http://gerrit.cloudera.org:8080/24037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id525b9b0578fb7f9cb3e0f8f4fa32f6fdae313b9 Gerrit-Change-Number: 24037 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 27 Feb 2026 13:58:27 +0000 Gerrit-HasComments: Yes
