Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24042 )
Change subject: IMPALA-14592: Read Row Lineage of Iceberg tables ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/24042/2/be/src/exec/hdfs-table-writer.cc File be/src/exec/hdfs-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/24042/2/be/src/exec/hdfs-table-writer.cc@39 PS2, Line 39: if (!table_desc_->IsIcebergTable()) { We'll be skipping this check for V1/V2 tables too which have been checked until now, isnt the condition too broad? Would checking for the format version instead be better? http://gerrit.cloudera.org:8080/#/c/24042/2/fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java: http://gerrit.cloudera.org:8080/#/c/24042/2/fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java@63 PS2, Line 63: if (column.isHidden()) { I think we should check if the column is null to prevent NPE. Its being done in line 88 right now, the order can be modified for null check. http://gerrit.cloudera.org:8080/#/c/24042/2/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/24042/2/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@418 PS2, Line 418: return super.getColumnsInHiveOrder().stream(). : filter(col -> !col.isHidden()). : collect(Collectors.toList()); nit: Shouldn't the dots be at the start of the line http://gerrit.cloudera.org:8080/#/c/24042/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/24042/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@188 PS2, Line 188: return super.getColumnsInHiveOrder().stream(). : filter(col -> !col.isHidden()). nit: Shouldn't the dots be at the start of the line: return super.getColumnsInHiveOrder() .stream() .filter(col -> !col.isHidden()) .collect(Collectors.toList()); http://gerrit.cloudera.org:8080/#/c/24042/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-row-lineage.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-row-lineage.test: PS2: Can we also add some test cases with partitioned tables. http://gerrit.cloudera.org:8080/#/c/24042/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-row-lineage.test@335 PS2, Line 335: PARQUET Why is this parquet, the table name suggests it should be orc. -- To view, visit http://gerrit.cloudera.org:8080/24042 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71b1076b25c9e7a0a6c9428b24abc986f5382c71 Gerrit-Change-Number: 24042 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Sat, 28 Feb 2026 18:27:30 +0000 Gerrit-HasComments: Yes
