Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24018 )
Change subject: IMPALA-14768: Add the operation type to the lineage graph ...................................................................... Patch Set 5: (1 comment) I have addressed Zoltan's comment on patch set 4. Let me know if there are additional suggestions. Thanks! http://gerrit.cloudera.org:8080/#/c/24018/4/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java: http://gerrit.cloudera.org:8080/#/c/24018/4/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@982 PS4, Line 982: turn OperationType.CREATEVIEW; > instanceof could be better here as it would handle subclasses as well if th Thanks for pointing this out Zoltan! Indeed, for queries like the following, operation type would be UNKNOWN if we do not use instanceof. create table lineage_test_db.like_alltypestiny_file like parquet 'hdfs:///test-warehouse/schemas/alltypestiny.parquet'; I will make the corresponding change in the next patch and will add a new test case to lineage.test too. -- To view, visit http://gerrit.cloudera.org:8080/24018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb94120a9bb1b994d4e681ea98521035bcc6510e Gerrit-Change-Number: 24018 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 02 Mar 2026 19:53:49 +0000 Gerrit-HasComments: Yes
