Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23942 )

Change subject: IMPALA-14230: Add catch-up mode for event processing
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23942/7/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:

http://gerrit.cloudera.org:8080/#/c/23942/7/tests/custom_cluster/test_events_custom_configs.py@2266
PS7, Line 2266:         "insert into {} values (1, 'bbb', 1); "
              :         "insert into {} values (2, 'ccc', 2); "
              :         "insert into {} values (3, 'ddd', 3); "
              :         "insert into {} values (4, 'eee', 4); "
              :         "insert into {} values (5, 'fff', 5);".format(tbl, tbl, 
tbl, tbl, tbl)
nit: use "{0}" so format() just needs one parameter

        "insert into {0} values (1, 'bbb', 1); "
        "insert into {0} values (2, 'ccc', 2); "
        "insert into {0} values (3, 'ddd', 3); "
        "insert into {0} values (4, 'eee', 4); "
        "insert into {0} values (5, 'fff', 5);".format(tbl)



--
To view, visit http://gerrit.cloudera.org:8080/23942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib906c06346d5d3159999eeac632e1318bc060065
Gerrit-Change-Number: 23942
Gerrit-PatchSet: 7
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Tue, 03 Mar 2026 13:28:49 +0000
Gerrit-HasComments: Yes

Reply via email to