Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24052 )
Change subject: IMPALA-14792: Try avoiding hadoop.fs.Path when loading Iceberg tables ...................................................................... Patch Set 4: (3 comments) Thanks for looking into it, nice speedup! http://gerrit.cloudera.org:8080/#/c/24052/4/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java File fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java: http://gerrit.cloudera.org:8080/#/c/24052/4/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@193 PS4, Line 193: iceApiTable.location() BaseTable.location() is not a simple getter, it should be moved outside the loop. http://gerrit.cloudera.org:8080/#/c/24052/4/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@365 PS4, Line 365: use slow path. We could log the URI here. Maybe with trace-level only, in case there are lots of unexpected URIs. http://gerrit.cloudera.org:8080/#/c/24052/4/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/24052/4/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@355 PS4, Line 355: path.length() >= tablePathStr_.length() + 1 nit: path.length() > tablePathStr_.length() -- To view, visit http://gerrit.cloudera.org:8080/24052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idce89117195e0fa64fdd6a6c576bce09ec2e75ea Gerrit-Change-Number: 24052 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2026 20:41:23 +0000 Gerrit-HasComments: Yes
