Balazs Hevele has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24033 )

Change subject: Fix infinite loops in threads causing ASAN heap-use-after-free
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

This solution is not good, no idea why it worked locally.

http://gerrit.cloudera.org:8080/#/c/24033/2/be/src/util/thread.cc
File be/src/util/thread.cc:

http://gerrit.cloudera.org:8080/#/c/24033/2/be/src/util/thread.cc@318
PS2, Line 318:     pthread_kill(thread_->native_handle(), SIGUSR2);
> I'm actually unclear what this is doing.
According to man 7 signal, the default is to Term, i.e. Terminate the process.
(Sending SIGTERM here isn't the same though, with that test_lineage_log_failure 
fails because it doesn't find the expected error message in the log, probably 
because the process is killed before.)

This fixing the test locally is probably some coincidence, and this is not the 
solution for sure.

It doesn't change the fact that the ASAN issue comes from the infinite loop in 
the thread trying to read data deallocated by a static duration variable's 
destructor, the question is how to fix this properly.



--
To view, visit http://gerrit.cloudera.org:8080/24033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97188e5ca2ace960c5db5cb44af44f42255902e8
Gerrit-Change-Number: 24033
Gerrit-PatchSet: 2
Gerrit-Owner: Balazs Hevele <[email protected]>
Gerrit-Reviewer: Balazs Hevele <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Wed, 04 Mar 2026 09:59:14 +0000
Gerrit-HasComments: Yes

Reply via email to