Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24064 )
Change subject: IMPALA-14803: Speed up Iceberg table minimal topic updates ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/24064/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/24064/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1946 PS2, Line 1946: if (BackendConfig.INSTANCE.isIncrementalMetadataUpdatesEnabled()) { Even when IncrementalMetadataUpdates is disabled, we can still do this optimization for the minimal topic mode. http://gerrit.cloudera.org:8080/#/c/24064/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1950 PS2, Line 1950: if( nit: add a space after "if" http://gerrit.cloudera.org:8080/#/c/24064/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1951 PS2, Line 1951: catalogTbl.setTable(tbl.toThriftMinimal()); Can we simply use toInvalidationObject()? catalogTbl = tbl.toInvalidationObject(); -- To view, visit http://gerrit.cloudera.org:8080/24064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If037a855dc5d2c4292347b34ebe0221477eae2fe Gerrit-Change-Number: 24064 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 05 Mar 2026 11:19:15 +0000 Gerrit-HasComments: Yes
