Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24073 )
Change subject: IMPALA-14810: Add Iceberg commit to catalog timeline ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/24073/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/24073/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2150 PS3, Line 2150: iceTxn.commitTransaction(); > Maybe log it here as well? Though right after invoking updateTableStatsViaI Skipped this one as catalogTimeline is not available here. I can add it as an argument if needed. http://gerrit.cloudera.org:8080/#/c/24073/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2853 PS3, Line 2853: iceTxn.commitTransaction(); > Log it in catalog timeline here as well? Done http://gerrit.cloudera.org:8080/#/c/24073/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3681 PS3, Line 3681: } > Log it in catalog timeline here as well? Done -- To view, visit http://gerrit.cloudera.org:8080/24073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a9a3110d63224ee6fb94ff1d2b966578de04864 Gerrit-Change-Number: 24073 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 06 Mar 2026 17:25:56 +0000 Gerrit-HasComments: Yes
