Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10690 )
Change subject: IMPALA-7046: introduce "global" debug_actions ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/10690/13/be/src/util/debug-util.cc File be/src/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/10690/13/be/src/util/debug-util.cc@296 PS13, Line 296: split(actions, debug_actions, is_any_of("|"), token_compress_on); > Apologies for being late. We recently had a couple of ASAN builds fail when I have have doubts that split() was the reason problem there, and especially that it could be a problem here. So I think this is fine to keep. -- To view, visit http://gerrit.cloudera.org:8080/10690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77663a539be18711a4f12c470ffd7474e3d69388 Gerrit-Change-Number: 10690 Gerrit-PatchSet: 13 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 20 Jun 2018 22:50:05 +0000 Gerrit-HasComments: Yes
