Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24074
Change subject: IMPALA-14482: Calcite planner: order by "random()" fixed ...................................................................... IMPALA-14482: Calcite planner: order by "random()" fixed The SortRemoveConstantKeysRule in Calcite was removing functions that did not have any column expressions in it. This commit makes a modification to that rule to ensure that the order by is not optimized out for non-deterministic functions. The test for this can be found in: test_sort.py::TestRandomSort::test_order_by_random Change-Id: I6ebf3aa11030d98b447d08d1364f5f65eb2ca661 --- M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaCoreRules.java A java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java 4 files changed, 129 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/24074/3 -- To view, visit http://gerrit.cloudera.org:8080/24074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6ebf3aa11030d98b447d08d1364f5f65eb2ca661 Gerrit-Change-Number: 24074 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
