Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )
Change subject: IMPALA-12137: do not copy parquet data for dict encoded pages ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24080/1/be/src/exec/parquet/parquet-column-chunk-reader.cc File be/src/exec/parquet/parquet-column-chunk-reader.cc: http://gerrit.cloudera.org:8080/#/c/24080/1/be/src/exec/parquet/parquet-column-chunk-reader.cc@387 PS1, Line 387: lueMemoryType::VAR_LEN_STR) && : Shouldn't this be the opposite, so each case when it is not dictionary encoded? -- To view, visit http://gerrit.cloudera.org:8080/24080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e Gerrit-Change-Number: 24080 Gerrit-PatchSet: 1 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 09 Mar 2026 13:10:48 +0000 Gerrit-HasComments: Yes
