Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23912 )
Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/23912/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java: http://gerrit.cloudera.org:8080/#/c/23912/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java@151 PS8, Line 151: if (returnsSingleRow(this)) { Is this still needed? Does it map to similar code in Impala's older planner? -- To view, visit http://gerrit.cloudera.org:8080/23912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755 Gerrit-Change-Number: 23912 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 09 Mar 2026 23:11:21 +0000 Gerrit-HasComments: Yes
