Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23237 )
Change subject: IMPALA-14285: Add SAML2 authentication support for Coordinator Web UI ...................................................................... Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/23237/18/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/23237/18/be/src/util/webserver.cc@356 PS18, Line 356: FLAGS_is_coordinator && !FLAGS_webserver_saml2_sp_callback_u > Yeah, makes sense, since only impalad can be coordinator anyway. Done http://gerrit.cloudera.org:8080/#/c/23237/18/be/src/util/webserver.cc@945 PS18, Line 945: const char* uri = request_info->uri; : const bool is_monitoring_endpoint = : strncmp(uri, kJsonMetricsPath, > Ack Done http://gerrit.cloudera.org:8080/#/c/23237/18/be/src/util/webserver.cc@952 PS18, Line 952: check_csrf_protection = false; > I may be missing something, but the problem is that this flag also skips th Ah, I wasn't thinking of cases where start-impala-cluster.py would be used beyond dev/testing. I don't know if that script is used outside dev/testing since most production instances of Impala use separate machines for each daemon. Can you please investigate whether or not start-impala-cluster.py is used outside of Impala dev/testing, and if it is, whether or not SAML auth is needed? -- To view, visit http://gerrit.cloudera.org:8080/23237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12540300529f9c240abf7196141ecb0ae6e37995 Gerrit-Change-Number: 23237 Gerrit-PatchSet: 19 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2026 21:43:52 +0000 Gerrit-HasComments: Yes
