Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24093 )
Change subject: IMPALA-14592: Enable OPTIMIZE for Iceberg V3 tables ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24093/1/fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java File fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java: http://gerrit.cloudera.org:8080/#/c/24093/1/fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java@a172 PS1, Line 172: : : : : Should we keep this statement in but changing just the version for comparison? http://gerrit.cloudera.org:8080/#/c/24093/1/fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java@282 PS1, Line 282: private void addRowLineageExprs(Analyzer analyzer, List<Expr> resultExprs) nit: these methods will be useful for UPDATE/MERGE as well, currently I don't know a better place for them, but they should be reusable in the future. -- To view, visit http://gerrit.cloudera.org:8080/24093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c3cc4b9aaa46e494e1aa4583c1a6aafecad48de Gerrit-Change-Number: 24093 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 13 Mar 2026 13:53:19 +0000 Gerrit-HasComments: Yes
