Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23777 )
Change subject: IMPALA-14370: [Patch 1 of 2] - OpenTelemetry Query Tracing Skips Queries with Leading Comments ...................................................................... Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/23777/18/fe/src/main/java/org/apache/impala/analysis/ParsedStatement.java File fe/src/main/java/org/apache/impala/analysis/ParsedStatement.java: http://gerrit.cloudera.org:8080/#/c/23777/18/fe/src/main/java/org/apache/impala/analysis/ParsedStatement.java@45 PS18, Line 45: // true if this is an alter table ddl statement Instead of adding all these checks, how about adding an isTraceable method and overriding it as needed? -- To view, visit http://gerrit.cloudera.org:8080/23777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1425b32006f81586bf75c2e4045d23bab91e1611 Gerrit-Change-Number: 23777 Gerrit-PatchSet: 18 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 13 Mar 2026 20:19:15 +0000 Gerrit-HasComments: Yes
