Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24105 )
Change subject: IMPALA-2083: Add PIVOT clause ...................................................................... Patch Set 2: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24105/2/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/24105/2/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@561 PS2, Line 561: createTransposeAggInfoForPivoting(analyzer, pivotHeaderSlotRefIndex_, headerValueMap); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/24105/2/fe/src/main/java/org/apache/impala/analysis/PivotTableRef.java File fe/src/main/java/org/apache/impala/analysis/PivotTableRef.java: http://gerrit.cloudera.org:8080/#/c/24105/2/fe/src/main/java/org/apache/impala/analysis/PivotTableRef.java@183 PS2, Line 183: "The argument of the aggregate in the PIVOT clause should be a path or a literal"); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/24105/2/tests/query_test/test_pivot_clause.py File tests/query_test/test_pivot_clause.py: http://gerrit.cloudera.org:8080/#/c/24105/2/tests/query_test/test_pivot_clause.py@27 PS2, Line 27: class TestPivotClause(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/24105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib799b772be18d2a3db8983b24e1068e7dfdf1ca9 Gerrit-Change-Number: 24105 Gerrit-PatchSet: 2 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 17 Mar 2026 08:54:06 +0000 Gerrit-HasComments: Yes
