Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23950 )
Change subject: IMPALA-12191: Add hardware and OS details to runtime profile ...................................................................... Patch Set 6: The change is looking good, though I still need to review the most recent patchset. Before I do, I wanted to point out a couple of things regarding your Gerrit workflow. -> Building for each Patchset: - I noticed that across all your changes, you’ve been running a full parallel-all-tests-ub2004 build to get the "Verified +1" label on every single patchset, even for minimal changes. - Please keep in mind that this label is not a mandate for every single patchset. - Although the job is named gerrit-verify-dryrun, it still builds and runs all the core tests. Triggering it for every small change consumes valuable CI resources and hogs the Jenkins queue for others. - A good rule of thumb: Trigger the full build on your first patchset, or if you make major architectural changes that impact multiple domains you are less familiar with. - Once you know which tests are impacted, you can just run those specific tests locally for any minor tweaks you make. If the reviewer believes your changes are ready to be committed, they will trigger a final, full build for you. -> Usage of distinct topic markers: - A topic marker is generally used to group together multiple commits that belong to the same overarching feature. Please refer to the following documentation. https://gerrit-review.googlesource.com/Documentation/intro-user.html#topics - Unless you have multiple commits that need to be grouped together under a single JIRA, using a topic marker for a single standalone commit is redundant. - As I had mentioned to you on Slack before, for single-commit changes, it is better to push normally without a topic, like most contributors do. I am not saying you should be overly conservative with your Gerrit contributions. I am just saving you the trouble and cutting through what is not required. -- To view, visit http://gerrit.cloudera.org:8080/23950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5a093b6cf9dd7dfa4321b79aeea95d6fc748dd4 Gerrit-Change-Number: 23950 Gerrit-PatchSet: 6 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 17 Mar 2026 11:55:34 +0000 Gerrit-HasComments: No
