Steve Carlin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24074 )
Change subject: IMPALA-14482: Calcite planner: order by "random()" fixed ...................................................................... IMPALA-14482: Calcite planner: order by "random()" fixed The SortRemoveConstantKeysRule in Calcite was removing functions that did not have any column expressions in it. This commit ensure that the isDeterministic method for the operator returns the correct value. The test for this can be found in: test_sort.py::TestRandomSort::test_order_by_random Change-Id: I6ebf3aa11030d98b447d08d1364f5f65eb2ca661 Reviewed-on: http://gerrit.cloudera.org:8080/24074 Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Steve Carlin <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaOperator.java 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Impala Public Jenkins: Verified Steve Carlin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/24074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6ebf3aa11030d98b447d08d1364f5f65eb2ca661 Gerrit-Change-Number: 24074 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]>
