Balazs Hevele has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24063 )

Change subject: IMPALA-14794: Implement small string optimization in Parquet 
scanner
......................................................................


Patch Set 12:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/24063/11/be/src/exec/parquet/parquet-column-readers.cc
File be/src/exec/parquet/parquet-column-readers.cc:

http://gerrit.cloudera.org:8080/#/c/24063/11/be/src/exec/parquet/parquet-column-readers.cc@861
PS11, Line 861:
> nit: missing space
Done


http://gerrit.cloudera.org:8080/#/c/24063/11/be/src/exec/parquet/parquet-column-readers.cc@864
PS11, Line 864:
> nit: requires +4 indent
Done


http://gerrit.cloudera.org:8080/#/c/24063/11/be/src/exec/parquet/parquet-column-readers.cc@955
PS11, Line 955:
> nit: requires +4 indent
Done


http://gerrit.cloudera.org:8080/#/c/24063/11/be/src/exec/parquet/parquet-column-readers.cc@956
PS11, Line 956:
> nit: requires +4 indent
Done


http://gerrit.cloudera.org:8080/#/c/24063/11/be/src/exec/parquet/parquet-column-readers.cc@967
PS11, Line 967:
> nit: requires +4 indent
Done



--
To view, visit http://gerrit.cloudera.org:8080/24063
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16c550d35cd6d3ec259b899b325611294137ccef
Gerrit-Change-Number: 24063
Gerrit-PatchSet: 12
Gerrit-Owner: Balazs Hevele <[email protected]>
Gerrit-Reviewer: Balazs Hevele <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 18 Mar 2026 13:36:36 +0000
Gerrit-HasComments: Yes

Reply via email to