Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24111 )
Change subject: IMPALA-14842: Guard doAs and impala.doas.user ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Thanks for taking care of this Michael! I left 2 very minor comments. http://gerrit.cloudera.org:8080/#/c/24111/1/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java File fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java: http://gerrit.cloudera.org:8080/#/c/24111/1/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@408 PS1, Line 408: operationHandle nit: Maybe we could remove 'operationHandle' on the left-hand side since this variable is unused? http://gerrit.cloudera.org:8080/#/c/24111/1/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@412 PS1, Line 412: TEST_USER_1 nit: Maybe we could change this to TEST_USER_3 to make it even clearer that it would be problematic if doAs could be different from impala.doas.user? -- To view, visit http://gerrit.cloudera.org:8080/24111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If783e48d5782e1c68e2b3fdd9e2aaabb45ddd6ff Gerrit-Change-Number: 24111 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 20 Mar 2026 00:10:52 +0000 Gerrit-HasComments: Yes
