Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24071 )
Change subject: IMPALA-14755:(part 1) Implement Puffin Blob reader and File writer ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/24071/6/be/src/util/thash128-util.h File be/src/util/thash128-util.h: http://gerrit.cloudera.org:8080/#/c/24071/6/be/src/util/thash128-util.h@24 PS6, Line 24: After the #include of "xxhash.h", I think we should #undef XXH_INLINE_ALL, so files including this header don't experience any side-effect. -- To view, visit http://gerrit.cloudera.org:8080/24071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I068a071f9db907064ccec8568db5234863eb4587 Gerrit-Change-Number: 24071 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 20 Mar 2026 10:32:09 +0000 Gerrit-HasComments: Yes
