Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22217 )

Change subject: WIP IMPALA-13475
......................................................................


Patch Set 6:

I think the central idea of this is solid. We definitely don't want to submit 
more tasks to the deserialization threads than we have memory to process. I 
think the current way we do this can produce starvation for large deferred 
messages, and we absolutely should do this.

I think this also includes other things that we could split off. IMPALA-13630 
is in here and once we rebase that will be gone. The changes to push the 
total_buffer_limit_ and num_buffered_bytes_ out to the SenderQueue to avoid the 
CAS might be a good thing, but they also seem a bit orthogonal to the 
starvation problem.


--
To view, visit http://gerrit.cloudera.org:8080/22217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8e2b07a19e4d30210d7903c01e75fba632a1de
Gerrit-Change-Number: 22217
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Comment-Date: Mon, 23 Mar 2026 02:53:01 +0000
Gerrit-HasComments: No

Reply via email to