Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24129
Change subject: IMPALA-14840: Pool can use more memory than Max Memory when Min/Max Query Memory limit is not set ...................................................................... IMPALA-14840: Pool can use more memory than Max Memory when Min/Max Query Memory limit is not set Impala should use memory-based query admission when Max Memory is set for the given pool. However, if Min Query Memory Limit, Max Query Memory Limit are missing, and query option MEM_LIMIT is not set, then currently queries can run with unlimited resources. This can cause a situation when Max Memory is specified, but the pool can consume basically unlimited memory. This patch fixes ScheduleState::UpdateMemoryRequirements() to not turn off memory-based query admission when Max Memory is set. The patch also removes an unused parameter of AdmissionController::CanAdmitRequest(). Testing * new admission controller backend tests added Change-Id: I4834964e4361895e10627a661831253ce676c129 --- M be/src/scheduling/admission-controller-test.cc M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M be/src/scheduling/schedule-state.cc M fe/src/main/java/org/apache/impala/analysis/Analyzer.java 5 files changed, 134 insertions(+), 30 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/24129/1 -- To view, visit http://gerrit.cloudera.org:8080/24129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4834964e4361895e10627a661831253ce676c129 Gerrit-Change-Number: 24129 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
